Skip to content

refactor: run security on package.json changes #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 29, 2022

No description provided.

@jsjoeio jsjoeio self-assigned this Sep 29, 2022
@jsjoeio jsjoeio marked this pull request as ready for review September 29, 2022 16:36
@jsjoeio jsjoeio requested a review from a team as a code owner September 29, 2022 16:36
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 16:38 Inactive
@github-actions
Copy link

github-actions bot commented Sep 29, 2022

✨ code-server dev build published to npm for PR #5602!

  • Last publish status: success
  • Commit: e432ce9

To install in a local project, run:

npm install @coder/code-server-pr@5602

To install globally, run:

npm install -g @coder/code-server-pr@5602

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #5602 (e432ce9) into main (7f0c4d7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5602   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0c4d7...e432ce9. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 17:02 Inactive
Comment on lines +7 to +8
paths:
- "package.json"
Copy link
Member

@code-asher code-asher Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add to the main push as well? Not a huge deal but it does kinda give a bad look to have seemingly failing CI on main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah good call!

@jsjoeio jsjoeio enabled auto-merge (squash) September 29, 2022 18:08
@jsjoeio jsjoeio requested a review from code-asher September 29, 2022 18:08
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 18:10 Inactive
@jsjoeio jsjoeio merged commit 8629d6a into main Sep 29, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-audit-check branch September 29, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants